Skip to content
Snippets Groups Projects
Commit 54026e1c authored by Reinhold Kainhofer's avatar Reinhold Kainhofer
Browse files

Fix warnings that cause problems (errors out) in developer mode

parent 958b875f
Branches
Tags
No related merge requests found
...@@ -3,9 +3,13 @@ class OpenTools_Ordernumber_Helper_Data extends Mage_Core_Helper_Abstract ...@@ -3,9 +3,13 @@ class OpenTools_Ordernumber_Helper_Data extends Mage_Core_Helper_Abstract
{ {
public function logitem($label, $item) public function logitem($label, $item)
{ {
Mage::Log($label . " " . get_class($item) . "\n", null, 'ordernumber.log'); if (is_array($item)) {
Mage::Log(is_array($item)?$item:$item->debug(), null, 'ordernumber.log'); Mage::Log($item, null, 'ordernumber.log');
Mage::Log(get_class_methods(get_class($item)), null, 'ordernumber.log'); } else {
Mage::Log($label . " " . get_class($item) . "\n", null, 'ordernumber.log');
Mage::Log($item->debug(), null, 'ordernumber.log');
Mage::Log(get_class_methods(get_class($item)), null, 'ordernumber.log');
}
} }
/* Return a random "string" of the given length taken from the given alphabet */ /* Return a random "string" of the given length taken from the given alphabet */
......
...@@ -24,6 +24,9 @@ class OpenTools_Ordernumber_Model_Backend_Counters extends Mage_Core_Model_Confi ...@@ -24,6 +24,9 @@ class OpenTools_Ordernumber_Model_Backend_Counters extends Mage_Core_Model_Confi
$helper = Mage::helper('ordernumber'); $helper = Mage::helper('ordernumber');
$session = Mage::getSingleton('core/session'); $session = Mage::getSingleton('core/session');
if (is_array($vals)) { if (is_array($vals)) {
if (!isset($vals['counter'])) $vals['counter'] = array();
if (!isset($vals['new_counter_type'])) $vals['new_counter_type'] = array();
if (!isset($vals['deletecounter'])) $vals['deletecounter'] = array();
// $helper->logitem("counter form values: ", $vals); // $helper->logitem("counter form values: ", $vals);
$model = $this->getModel(); $model = $this->getModel();
// First, handle new counters // First, handle new counters
...@@ -91,6 +94,7 @@ class OpenTools_Ordernumber_Model_Backend_Counters extends Mage_Core_Model_Confi ...@@ -91,6 +94,7 @@ class OpenTools_Ordernumber_Model_Backend_Counters extends Mage_Core_Model_Confi
$session->addSuccess($helper->__('Successfully deleted counter \'%s\' (type: %s, scope: %s) with value %d', $session->addSuccess($helper->__('Successfully deleted counter \'%s\' (type: %s, scope: %s) with value %d',
$counter->getNumberFormat(), $model->readableType($counter->getNumberType()), $model->readableScope($counter->getNumberScope()), $counter->getCount())); $counter->getNumberFormat(), $model->readableType($counter->getNumberType()), $model->readableScope($counter->getNumberScope()), $counter->getCount()));
} }
$this->setValue('');
} }
} }
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment